Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing slash in hook url #61

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Fix missing slash in hook url #61

merged 1 commit into from
Nov 9, 2019

Conversation

ziouf
Copy link
Contributor

@ziouf ziouf commented Nov 8, 2019

There is an issue with WebHook/SystemHook creation.

In created hook there is a missing '/' in the target url between 'rootUrl' and 'pronoun'.

Here is my contrib.

Regards

@jetersen
Copy link
Member

jetersen commented Nov 8, 2019

link to see current commit author: https://github.com/jenkinsci/gitlab-branch-source-plugin/pull/61/commits/976b9de4378edad6de3cc5d27800309bbde9f69a.patch

@ziouf
You might want to set up an email alias on your GitHub account 🥇
https://help.github.com/articles/adding-an-email-address-to-your-github-account/

Or look into fixing your git user.email config 😅
https://help.github.com/articles/setting-your-commit-email-address-in-git
then you would need to amend your commits: https://stackoverflow.com/a/3042512
after changing author

to get proper credit for your commits 🏆

@ziouf
Copy link
Contributor Author

ziouf commented Nov 8, 2019

Commit amended.
Thank you @Casz

@jetersen jetersen merged commit 19b5767 into jenkinsci:master Nov 9, 2019
@jetersen
Copy link
Member

This should have been done differently 😓

We need to have an method that will ensure the slash is there.
I am seeing webhooks with double slashes https://jenkins.company.local//gitlab-webhook/post

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants