Do not suffix MR name with merge strategy if only one is chosen #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumelecerf
changed the title
In 44b8b5a, the loop on ChangeRequestCheckoutStrategy has been modified, but the check for the number of them has not been updated, resulting in MR names being always suffixed with the strategy used (-head or -merge), even when there is only one chosen.
guillaumelecerf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 44b8b5a#r36271968, the loop on
ChangeRequestCheckoutStrategyhas been modified, but the check for the number of them has not been updated, resulting in MR names being always suffixed with the strategy used (-head or -merge), even when there is only one chosen.strategies.size()must be changed to actually be the size of theSet<ChangeRequestCheckoutStrategy>, and not the size of theMap<Boolean, Set>which will always be > 1.