-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of hashicorp-vault-pipeline-plugin #61
Conversation
Any update on this PR? What is required to merge this? |
I was exploring how to properly hide secrets 😓 |
Ah okay, I did some quick testing with that as well, but it seemed like it requires a complete rewrite of the current step, as the others I have found, are all build wrappers so they keep control over the context, while our step just injects some values in the environment. |
Hi @Casz, any updates on this PR? Are we still waiting on masking passwords? Edit: I just saw there are quite a few changes to VaultAccessor - so I do not think PR will work when merged right now. |
} | ||
``` | ||
|
||
##### Masking secrets in console output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In azure-keyvault plugin I used a block scoped step not the environment option and secrets were hidden fine:
https://github.com/jenkinsci/azure-keyvault-plugin#declarative
Any updates for these changes? The current https://github.com/jenkinsci/hashicorp-vault-pipeline-plugin is broken |
No longer relevant after #174 Use |
Thanks @jetersen, I didn't know #174 was an option! If anyone finds this in the future, the PR above makes the Usage docs: https://www.jenkins.io/doc/pipeline/steps/hashicorp-vault-plugin |
No description provided.