refactor kubernetes config #803
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylvain Gilgen <gilgen@puzzle.ch>
Signed-off-by: Sylvain Gilgen <gilgen@puzzle.ch>
|
Any input on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The goal of this PR is to start a discussion about how feature toggles should be handled especially
controller.JCasC.defaultConfig. In my opinion the current feature toggles have too many unclear consequences. If I disable thecontroller.JCasC.defaultConfigdoesn't mean I want to disableagentIt's not in the same subtree it shouldn't have an impact. Furthermore if I disableagent.enabledI would assume that all keys underneath it would be disabled but that isn't the case.This changes in this PR are a proposal and aren't final.
I would be glad for your input:
@maorfr
@torstenwalter
@mogaal
@wmcdona89
@timja
Which issue this PR fixes
Special notes for your reviewer
Checklist