[JENKINS-41631] Deleting the Maven Embedder dependency from the test harness #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
stephenc
reviewed
Jun 14, 2017
| @@ -2512,5 +2460,4 @@ private NameValuePair getCrumbHeaderNVP() { | |||
| return new NameValuePair(jenkins.getCrumbIssuer().getDescriptor().getCrumbRequestField(), | |||
| jenkins.getCrumbIssuer().getCrumb( null )); | |||
| } | |||
| public static final List<String> PLUGIN_GROUPIDS = new ArrayList<String>(Arrays.asList("org.jvnet.hudson.plugins", "org.jvnet.hudson.main")); | |||
There was a problem hiding this comment.
On the basis of this line alone, I argue this is 100% safe to remove
|
@reviewbybees done |
|
Missed this PR. I am not sure it causes no regressions in plugins like Maven Project, but +1 for removing it taking the mess in the code into account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Critical for JENKINS-41631 since some of the harder problems relate to random libraries pulled in via the
lib-jenkins-maven-embedderdependency.Taking a closer look at the harness code using this library, I could not find any realistic cases where it would actually be used. We already look up test dependencies from the classpath. Furthermore, the group IDs covered are old Hudson names no longer used by Jenkins.
@reviewbybees