Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bundled LDAP plugin in order to restore missing help files #1682

Merged
merged 1 commit into from
May 4, 2015
Merged

Update bundled LDAP plugin in order to restore missing help files #1682

merged 1 commit into from
May 4, 2015

Conversation

albers
Copy link
Member

@albers albers commented Apr 30, 2015

In e91782e some help files were removed from core because they were moved to LDAP plugin in jenkinsci/ldap-plugin@98db723.

Unfortunately, these help files are not available in LDAP plugin versions prior to 1.11 and thus missing in current Jenkins releases.

An alternative would be to recover the help files in Jenkins core. But this would result in duplicated content when the user manually updates the LDAP plugin.

@albers
Update bundled LDAP plugin in order to restore missing help files
824662a 
In e91782e some help files were removed
from core because they were moved to LDAP plugin. 
Unfortunately, these help files are not available in LDAP plugin
versions prior to 1.11.
@oleg-nenashev
Copy link
Member

👍

@albers
Copy link
Member Author

albers commented May 2, 2015

@jglick what's your opinion here?

@jtnord
Copy link
Member

jtnord commented May 2, 2015

👍
@olivergondza should this be backporting to the next LTS.

@KostyaSha
Copy link
Member

👍

@oleg-nenashev
Copy link
Member

Lets give @jglick some time to respond, because there was a direct question.

@jglick
Copy link
Member

jglick commented May 4, 2015

👍

oleg-nenashev added a commit that referenced this pull request May 4, 2015
@oleg-nenashev
Merge pull request #1682 from albers/ldap-plugin-1.11
b7ad986 
Update bundled LDAP plugin in order to restore missing help files
@oleg-nenashev oleg-nenashev merged commit b7ad986 into jenkinsci:master May 4, 2015
oleg-nenashev added a commit that referenced this pull request May 4, 2015
@oleg-nenashev
Noting #1682
43188ec
@jglick
Copy link
Member

jglick commented May 4, 2015

If you want this to be an lts-candidate you need to retroactively file an issue for it.

@albers albers deleted the ldap-plugin-1.11 branch May 4, 2015 18:13
@albers
Copy link
Member Author

albers commented May 5, 2015

@jglick @olivergondza created JENKINS-28233 and labelled it as lts-candidate.

@oleg-nenashev
Copy link
Member

@albers
Harald, please also update changelogs

@albers
Copy link
Member Author

albers commented May 5, 2015

@oleg-nenashev Please give me a hint where I should do that. What changelog besides changelog.html should be updated?

@oleg-nenashev
Copy link
Member

I suppose it's the only changelog to be updated. Sorry if I've missed the
change
On May 5, 2015 12:10, "Harald Albers" notifications@github.com wrote:

@oleg-nenashev https://github.com/oleg-nenashev Please give me a hint
where I should do that. What changelog besides changelog.html should be
updated?

—
Reply to this email directly or view it on GitHub
#1682 (comment).

@albers
Copy link
Member Author

albers commented May 5, 2015

@oleg-nenashev No problem, thanks for reminding me.

tfennelly added a commit to tfennelly/jenkins that referenced this pull request May 15, 2015
@tfennelly
Merge branch 'master' into extensionlist-listener
2c6bc73 
* master: (61 commits)
  [JENKINS-28384] Noting merge of jenkinsci#1700.
  update changelog: PR 1682 -> issue 28233, fix markup issue
  Remove duplicated 1.613 section from changelog
  [FIXED JENKINS-28384] NPE when Node.toComputer → null.
  Refactor fingerprint classes: Javadoc and annotations
  fixup ce747f9
  Refactor ArgumentListBuilder#toWindowsCommand
  Improve ArgumentListBuilder#toWindowsCommand test coverage
  Forgotten @test annotation
  updated changelog for release
  updated changelog for release
  [maven-release-plugin] prepare release jenkins-1.613
  [maven-release-plugin] prepare for next development iteration
  Report launcher exited before establishing the channel
  Remove erroneous '+ ' from log message.
  Increase visibility of Java 7 requirement
  Expose SlaveComputer#getLogDir() explicitly
  [FIXED JENKINS-28227] Switch to Enblish locale in RunTest#getDurationString to test messages.
  Noting jenkinsci#1591
  Noting jenkinsci#1682
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@albers @oleg-nenashev @jtnord @KostyaSha @jglick