[JENKINS-33599] write file with admin password for installer #2138
Conversation
|
@reviewbybees |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| securityRealm.createAccount(SetupWizard.initialSetupAdminUserName, randomUUID); | ||
|
|
||
| // JENKINS-33599 - write to a file in the jenkins home directory | ||
| FileUtils.write(getInitialAdminPasswordFile(), randomUUID); |
There was a problem hiding this comment.
There may be IOException here.
Do you want to interrupt the installation in such case?
There was a problem hiding this comment.
@oleg-nenashev yes, startup of the installer should fail if it can't read/write the file, that's the only way a user could really continue
…ile-for-security-token
|
You seem to be making deeper changes to how the initial admin user works than simply printing the password to a file in addition to printing it to the log. Those changes might be fine—they seem to make the code simpler—but it would be appropriate to explain them in the PR description. |
|
I've taken this over and this is now in #2142 |
To make finding the initial admin password easier, write it to a file and display the location of the file so the user knows exactly where to look. Also removed tracking in the user object, as this was just so the token was available across restarts (previously using a custom UserProperty).
This addresses: https://issues.jenkins-ci.org/browse/JENKINS-33599