[FIXED JENKINS-33599] write file with admin password for installer #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile-for-security-token
Note that we already go much beyond what normal webapps do, which is to show the initial configuration dialog unauthenticated to anyone with access.
In fact it's desirable not to have them to keep things more POJO
and its dataflow analysis warning
kohsuke
changed the title
|
@reviewbybees in particular @daniel-beck |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
... so that the nature of this file is little more clearer
| <j:if test="${error}"> | ||
| <div class="alert alert-danger"> | ||
| <strong>${%ERROR:} </strong> | ||
| ${%There is a problem with the security token, please check the logs for the correct token} | ||
| ${%The password entered is incorrect, please check the file for the correct password} |
There was a problem hiding this comment.
Given how often the wording of these messages change, maybe it makes sense to move them into the .properties file?
|
👍 |
kohsuke
added a commit
that referenced
this pull request
Mar 19, 2016
[FIXED JENKINS-33599] write file with admin password for installer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes over PR #2138.
To make finding the initial admin password easier, write it to a file and display the location of the file so the user knows exactly where to look. Also removed tracking in the user object, as this was just so the token was available across restarts (previously using a custom
UserProperty).This addresses: https://issues.jenkins-ci.org/browse/JENKINS-33599
In addition to initial PR #2138, the following has been added to address the comments:
$JENKINS_HOME/secretswhere other files of this nature are in.