Using RestartableJenkinsRule.then #2959
Conversation
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
There was a problem hiding this comment.
Reviewer diff: https://github.com/jenkinsci/jenkins/pull/2959/files?w=1
|
@reviewbybees done. Ready to go once the changes pass. |
So? They are not exposed to plugins. |
jglick
added
ready-for-merge
|
Passing on Linux. The Windows nodes seem to be extremely slow. Need to investigate whether something in this PR is actually responsible. |
test/pom.xml
Outdated
| @@ -53,7 +53,7 @@ THE SOFTWARE. | |||
| <dependency> | |||
| <groupId>${project.groupId}</groupId> | |||
| <artifactId>jenkins-test-harness</artifactId> | |||
| <version>2.20</version> | |||
| <version>2.24</version> | |||
There was a problem hiding this comment.
I am wondering if jenkinsci/jenkins-test-harness#63 is responsible for the extremely slow Windows builds (2× time on Linux), or if this is just random bad luck. Other recent PRs seem to complete, though certainly more slowly than I would expect.
oleg-nenashev
added
the
on-hold
|
I have put it on hold to let @jglick investigate the JTH issues. |
Jenkinsfile
Outdated
| @@ -32,7 +32,7 @@ for(i = 0; i < buildTypes.size(); i++) { | |||
|
|
|||
| // Now run the actual build. | |||
| stage("${buildType} Build / Test") { | |||
| timeout(time: 180, unit: 'MINUTES') { | |||
| timeout(time: 240, unit: 'MINUTES') { | |||
There was a problem hiding this comment.
Getting timeouts; cf. #2967.
oleg-nenashev
added
the
unresolved-merge-conflict
|
Merge conflict |
jglick
removed
on-hold
| @@ -255,6 +256,7 @@ public void encodingAndLocale() throws Exception { | |||
| // -ssh mode does not pass client locale or encoding | |||
| } | |||
|
|
|||
| @Ignore("TODO JENKINS-46659 seems to be broken") | |||
There was a problem hiding this comment.
JENKINS-46659 appears to have been the cause of the earlier failures, as well as those in #2754.
Downstream of jenkinsci/jenkins-test-harness#66.
@reviewbybees