fix: change icon to symbol

[ealvesss]

See JENKINS-69715.

Before

After

File addtion:

File modification:

File deletion:

Proposed changelog entries

• Replace 'Changes' view icon with a symbol.

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
  • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[NotMyFault]

Hey,

thanks for your PR! The icon has three states, according to the corresponding Java class: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/scm/EditType.java#L57-L59

The appropriate icon is filled in depending on the SCM operation that took place. We should keep that up, rather than replacing the icons with a generic symbol, no?

[ealvesss]

Hey,

thanks for your PR! The icon has three states, according to the corresponding Java class: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/scm/EditType.java#L57-L59

The appropriate icon is filled in depending on the SCM operation that took place. We should keep that up, rather than replacing the icons with a generic symbol, no?

Where i can test the changes? I fixed it already in the right way.

which screen can I test every single states? (the edit icon I know)

Edit
I found a way to do. I think now is ok.

Any problem, let me know!

[NotMyFault]

I went ahead and cleaned up the improper merge. Although, I'm not too sure about changing the reference from 'delete' to 'trash', because it's available in Jelly.

[ealvesss]

I went ahead and cleaned up the improper merge. Although, I'm not too sure about changing the reference from 'delete' to 'trash', because it's available in Jelly.

Any change needed?

[daniel-beck]

As above.

[NotMyFault]

I went ahead and updated the screenshots matching the new output, looks good to me, thanks for the PR.

[uhafner]

It is better than before! I'm not sure if it is a good idea to reuse the pencil, as this icon has a meaning for me: to actively edit something. But since there is no +/- symbol available right now I am fine with this change (in the Git forensics plugin I am using this one: https://github.com/jenkinsci/forensics-api-plugin/blob/master/src/main/resources/images/symbols/diff-stat.svg).

Changes addressed

[NotMyFault]

Would someone from @jenkinsci/core-security-review mind taking a look, please? :)

[Kevin-CB]

Sorry for the delay, from a security aspect, I see no issues with this PR 🙂

[NotMyFault]

/label ready-for-merge

---

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!