Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump json5 from 1.0.1 to 1.0.2 in /war #7563

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 3, 2023

Bumps json5 from 1.0.1 to 1.0.2.

Release notes

Sourced from json5's releases.

v1.0.2

  • Fix: Properties with the name __proto__ are added to objects and arrays. (#199) This also fixes a prototype pollution vulnerability reported by Jonathan Gregson! (#295). This has been backported to v1. (#298)
Changelog

Sourced from json5's changelog.

Unreleased [code, diff]

v2.2.3 [code, diff]

  • Fix: json5@2.2.3 is now the 'latest' release according to npm instead of v1.0.2. (#299)

v2.2.2 [code, diff]

  • Fix: Properties with the name __proto__ are added to objects and arrays. (#199) This also fixes a prototype pollution vulnerability reported by Jonathan Gregson! (#295).

v2.2.1 [code, diff]

v2.2.0 [code, diff]

  • New: Accurate and documented TypeScript declarations are now included. There is no need to install @types/json5. (#236, #244)

v2.1.3 [code, diff]

  • Fix: An out of memory bug when parsing numbers has been fixed. (#228, #229)

v2.1.2 [code, diff]

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code, used by dependency tooling labels Jan 3, 2023
@NotMyFault
Copy link
Member

This is a transitive dependency of babel and loader-utils.

Screenshot 2023-01-03 at 21 50 56

This will be addressed in the corresponding packages, once babel cuts a new released and webpack/loader-utils#240 is merged and released.

@NotMyFault NotMyFault added the proposed-for-close There is no consensus about feasibility of this PR, and maintainers do not see a way forward for it label Jan 3, 2023
@basil
Copy link
Member

basil commented Jan 3, 2023

https://github.com/json5/json5/releases/tag/v1.0.2 describes the advantages to merging this PR. What are the disadvantages?

@NotMyFault
Copy link
Member

There are no advantages in merging this PR, but also no disadvantages in closing it because the vulnerability doesn't affect Jenkins. Merging this PR silences dependabot only.

@basil
Copy link
Member

basil commented Jan 3, 2023

There are no advantages in merging this PR

Picking up json5/json5#298 is not an advantage?

@NotMyFault
Copy link
Member

Picking up json5/json5#298 is not an advantage?

Merging does only silence dependabot, given we're not impacted by it. But we surely can merge this PR, I don't mind too much about silencing dependabot.

@NotMyFault NotMyFault added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog and removed proposed-for-close There is no consensus about feasibility of this PR, and maintainers do not see a way forward for it labels Jan 4, 2023
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if we do not need the functionality of a newer version, remaining on an older version when a newer version is available is itself a maintenance liability.

@NotMyFault NotMyFault merged commit 2844417 into master Jan 5, 2023
@NotMyFault NotMyFault deleted the dependabot/npm_and_yarn/war/json5-1.0.2 branch January 5, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code, used by dependency tooling ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants