Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish French translations for Update Center #8672

Merged

Conversation

Mysterious-Dev
Copy link
Contributor

All is in the title ^^.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@MarkEWaite MarkEWaite changed the title Finish translations for Update Center Finish French translations for Update Center Nov 1, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They seem reasonable to me. I checked translate.google.com to convert them back to my native language (English) and the resulting English translation is good.

Would like one of the native French speakers to review and approve as well. @dduportal or @smerle33 or @lemeurherve or @gounthar

@MarkEWaite MarkEWaite self-assigned this Nov 1, 2023
@Mysterious-Dev
Copy link
Contributor Author

@gounthar I changed ^^.

Copy link

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

Copy link

@hervelemeur hervelemeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion, LGTM otherwise.

Please\ wait\ while\ Jenkins\ is\ restarting=Veuillez attendre pendant que Jenkins redémarre
Your\ browser\ will\ reload\ automatically\ when\ Jenkins\ is\ ready.=Votre navigateur se connectera automatiquement quand Jenkins sera prêt
Your\ browser\ will\ reload\ automatically\ when\ Jenkins\ is\ ready.=Votre navigateur se connectera automatiquement quand Jenkins sera prêt.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Your\ browser\ will\ reload\ automatically\ when\ Jenkins\ is\ ready.=Votre navigateur se connectera automatiquement quand Jenkins sera prêt.
Your\ browser\ will\ reload\ automatically\ when\ Jenkins\ is\ ready.=Votre navigateur se rafraîchira automatiquement quand Jenkins sera prêt.

@Mysterious-Dev
Copy link
Contributor Author

Small suggestion, LGTM otherwise.

@hervelemeur I applied your suggestion ^^.

Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite
Copy link
Contributor

/label ready-to-merge

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

Copy link

I wasn't able to add the following labels: ready-to-merge

Check that the label exists and is spelt right then try again.

@MarkEWaite MarkEWaite added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted skip-changelog Should not be shown in the changelog and removed rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Nov 3, 2023
@MarkEWaite
Copy link
Contributor

I've labeled it as skip-changelog because the submitter did not retain the pull request template and did not provide a proposed changelog entry. @Mysterious-Dev if you would like it mentioned in the changelog, could you update the pull request to use the template and include a proposed changelog entry? No issue for me if we don't mention it in the changelog as well.

Thanks again for the contribution!

@Mysterious-Dev
Copy link
Contributor Author

I've labeled it as skip-changelog because the submitter did not retain the pull request template and did not provide a proposed changelog entry. @Mysterious-Dev if you would like it mentioned in the changelog, could you update the pull request to use the template and include a proposed changelog entry? No issue for me if we don't mention it in the changelog as well.

Thanks again for the contribution!

No that's fine. You can keep this excluded from the changelog ^^.

@NotMyFault NotMyFault merged commit 9463397 into jenkinsci:master Nov 4, 2023
17 checks passed
@Mysterious-Dev Mysterious-Dev deleted the update-page-translations branch November 4, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants