Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phrasing error in Polish translation of install wizard #9185

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

jwojnarowicz
Copy link
Contributor

@jwojnarowicz jwojnarowicz commented Apr 22, 2024

Update Polish translation for installWizard_skipFirstUser to more clear definition of action which states that "skip" means "pomiń[PL]"

Although it is a minor change, it significantly improves context and describes the action that the button takes. The previous one translates into "Continue as an administrator" which might suggets continuing as the user that is being created since we create first "admin" user in this wizard.

New translation is more clear as it translates into "Skip and continue as an administrator" which signals the skipping of first user creation. New translation corresponds directly with English "Skip and continue as admin".

Proposed changelog entries

  • Update Polish translation for install wizard message to skip first user.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Update translation for installWizard_skipFirstUser to more clear definition of action which states that "skip" means "pomiń[PL]"
Copy link

welcome bot commented Apr 22, 2024

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@daniel-beck
Copy link
Member

Skip and continue as an administrator

FWIW the intention is to refer to the user by the generated default user name admin. It's going to be an administrator account (account with Overall/Administer permission) no matter what you call it.

This probably should be improved in the English version to make this clearer, perhaps through formatting similar to the one in the previous paragraph.

@jwojnarowicz
Copy link
Contributor Author

@daniel-beck I agree as in English version it is admin.
My suggested change aimed to introduce clear description of the action, as now it does not inform the user of skipping.

Do you suggest changing it to admin as it refers to the name of the user rather than administrator which may be mistaken with permissions?

@daniel-beck
Copy link
Member

Do you suggest changing it to admin as it refers to the name of the user rather than administrator which may be mistaken with permissions?

Yes.

Change translation from "administrator" to "admin" to reflect the default admin username
@jwojnarowicz
Copy link
Contributor Author

Changed it to admin 😉

Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google Translate looks reasonable

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 24, 2024
@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label Apr 24, 2024
@MarkEWaite MarkEWaite changed the title Update Polish translation in pluginSetupWizard_pl.properties Fix phrasing error in Polish translation of install install wizard Apr 24, 2024
@MarkEWaite MarkEWaite changed the title Fix phrasing error in Polish translation of install install wizard Fix phrasing error in Polish translation of install wizard Apr 24, 2024
@NotMyFault NotMyFault merged commit 7468bef into jenkinsci:master Apr 25, 2024
17 checks passed
Copy link

welcome bot commented Apr 25, 2024

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants