-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix phrasing error in Polish translation of install wizard #9185
Fix phrasing error in Polish translation of install wizard #9185
Conversation
Update translation for installWizard_skipFirstUser to more clear definition of action which states that "skip" means "pomiń[PL]"
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
FWIW the intention is to refer to the user by the generated default user name This probably should be improved in the English version to make this clearer, perhaps through formatting similar to the one in the previous paragraph. |
@daniel-beck I agree as in English version it is admin. Do you suggest changing it to |
Yes. |
Change translation from "administrator" to "admin" to reflect the default admin username
Changed it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google Translate looks reasonable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.
/label ready-for-merge
Congratulations on getting your very first Jenkins core pull request merged 🎉🥳 |
Update Polish translation for
installWizard_skipFirstUser
to more clear definition of action which states that "skip" means "pomiń[PL]"Although it is a minor change, it significantly improves context and describes the action that the button takes. The previous one translates into "Continue as an administrator" which might suggets continuing as the user that is being created since we create first "admin" user in this wizard.
New translation is more clear as it translates into "Skip and continue as an administrator" which signals the skipping of first user creation. New translation corresponds directly with English "Skip and continue as admin".
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist