[JENKINS-73166] Fix PKCS#12 certificate save to credentials #9286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-73166 - Fix PKCS#12 certificate save to credentials
Alternative to #9284, fixes a bug introduced in #9136
The
execScript
code is for IE only and removing it was correct. Howevergeval
cannot simply calleval
since it has to use the global scope.Automated tests of this case don't provide enough benefit for the effort required. No added test automation,.
Testing done
Confirmed that I can duplicate the problem before this change and that after this change the PKCS#12 credential checkbox works as expected.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@MarkEWaite
Before the changes are marked as
ready-for-merge
:Maintainer checklist