Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73166] Fix PKCS#12 certificate save to credentials #9286

Merged
merged 1 commit into from
May 19, 2024

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented May 17, 2024

JENKINS-73166 - Fix PKCS#12 certificate save to credentials

Alternative to #9284, fixes a bug introduced in #9136

The execScript code is for IE only and removing it was correct. However geval cannot simply call eval since it has to use the global scope.

Automated tests of this case don't provide enough benefit for the effort required. No added test automation,.

Testing done

Confirmed that I can duplicate the problem before this change and that after this change the PKCS#12 credential checkbox works as expected.

Proposed changelog entries

  • Allow PKCS 12 certificates to be added to the credentials store again. Regression in 2.453.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@MarkEWaite

Before the changes are marked as ready-for-merge:

Maintainer checklist

@MarkEWaite MarkEWaite self-assigned this May 17, 2024
@MarkEWaite MarkEWaite added bug For changelog: Minor bug. Will be listed after features regression-fix Pull request that fixes a regression in one of the previous Jenkins releases labels May 17, 2024
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 18, 2024
@MarkEWaite MarkEWaite merged commit 35b3959 into jenkinsci:master May 19, 2024
16 checks passed
@zbynek zbynek deleted the patch-3 branch May 19, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants