Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage the version of jakarta.servlet-api consistently with the version of jakarta.servlet.jsp.jstl-api #9288

Merged
merged 1 commit into from
May 19, 2024

Conversation

basil
Copy link
Member

@basil basil commented May 18, 2024

This is currently managed in plugin-pom, but it would make more sense for it to be managed here since it is tied to the version of Jetty/Winstone/Stapler that we provide in core. Adding this now will allow us to eventually stop managing it in plugin-pom. Besides which, this is more consistent with the fact that we already manage a similar library, jakarta.servlet.jsp.jstl-api.

Testing done

CI build; also tested compilation of text-finder with this change and the existing plugin parent POM (no regression)

Proposed changelog entries

  • JENKINS-XXXXX, human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@basil basil added the skip-changelog Should not be shown in the changelog label May 18, 2024
@MarkEWaite MarkEWaite merged commit 02cc1cc into jenkinsci:master May 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants