Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JEP-227] Links to japicmp report will be dead #331

Merged
merged 1 commit into from
Nov 7, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions jep/227/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ In mostly chronological order, though of course many tasks can be parallelized:
** `ldap` needs extensive work.
* Run acceptance tests (ATH) and plugin compatibility tests (PCT) against core plus a representative subset of plugins.
* Interactively verify that core plus all plugins mentioned in the setup wizard (even if not `suggested`) seem to work.
* Evaluate the link:https://ci.jenkins.io/job/Core/job/jenkins/job/PR-4848/API_20compatibility/japicmp.html[japicmp report for Jenkins core] to make sure that all incompatible as well as compatible API changes are expected.
* Evaluate the japicmp report for Jenkins core to make sure that all incompatible as well as compatible API changes are expected.
* Solicit code reviews on all open associated pull requests to core and plugins.
* Create a compatibility chart associated with this JEP listing all known plugins that might be affected by this change, with their current status.
* Define a Jira label for regressions suspected to be related to this migration,
Expand Down Expand Up @@ -383,8 +383,6 @@ producing a much shorter report.
Some matches are from plugins which already have preparatory patches.
A number of the remaining matches are Spring types that are _probably_ compatible from 2.x to 5.x.

You can also check the link:https://ci.jenkins.io/job/Core/job/jenkins/job/PR-4848/API_20compatibility/japicmp.html[japicmp report for Jenkins core].

== Security

This JEP changes Jenkins code fundamental to security and so introduces inherent security risks.
Expand Down Expand Up @@ -420,8 +418,6 @@ CloudBees is running the ATH & PCT against patched Jenkins core and many popular
** link:https://github.com/jenkinsci/jenkins/pull/4848[jenkins #4848] (upgrade to Spring Security 5 by jglick)
* Tracking
** link:compatibility.adoc[Compatibility table]
* Generated reports
** link:https://ci.jenkins.io/job/Core/job/jenkins/job/PR-4848/API_20compatibility/japicmp.html[japicmp report for Jenkins core]
* Searching for usages of Acegi Security in plugins
** link:https://github.com/jenkins-infra/usage-in-plugins/pull/15[usage-in-plugins #15] (PoC by Wadeck)
** link:https://github.com/jenkins-infra/usage-in-plugins/pull/16[usage-in-plugins #16] (general improvement by jglick)
Expand Down