[JENKINS-43693] improve multi-branch pipeline support

[daspilker]

No description provided.

[darxriggs]

@daspilker other multi-branch sources like the one for Bitbucket are currently provided via dynamic DSL. Do you have an idea how to easily mark the id field as mandatory for these too?

[daspilker]

@darxriggs Job DSL uses the same means as Pipeline to provide the dynamic DSL. See https://jenkins.io/doc/developer/plugin-development/pipeline-integration/#constructor-vs-setters.

So the plugins should declare the id field in a @DataBoundConstructor. The plugin can even provide documentation for the parameter, see https://github.com/jenkinsci/structs-plugin/blob/structs-parent-1.19/plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableParameter.java#L115.

Job DSL should not contain any special handling for plugins, this should be fixed in the plugins.

Can you try to get this fixed in the relevant plugins?

[darxriggs]

There was a change in the scm-api-plugin about 2 years ago in the opposite direction - see JENKINS-44891 and jenkinsci/scm-api-plugin#41.