Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use core default driver for XStream #1390

Merged
merged 1 commit into from Sep 27, 2023

Conversation

basil
Copy link
Member

@basil basil commented Sep 21, 2023

The XStream default driver (based on XML Pull Parser 3rd edition) is one that core no longer prefers or uses for various reasons, including bugs parsing emoji in modern XML files. Instead core now uses the Streaming API for XML (StAX) that is built into modern versions of the Java Platform runtime environment. I have been working to slowly remove the old XPP3 parser from core, but I discovered that this plugin still had a hard-coded reference to it in one place and was broken when I removed the old driver from core. To avoid this problem I am instead having this plugin use core's default driver, which in newer versions is StAX.

Testing done

I ran this plugin's tests against a core with XPP3 removed and observed they started failing. After this PR and jenkinsci/nested-view-plugin#43 they now pass.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@basil basil added the internal label Sep 21, 2023
@basil basil requested a review from a team as a code owner September 21, 2023 23:44
@jamietanna
Copy link
Contributor

@basil want me to merge? Or you happy to?

@basil
Copy link
Member Author

basil commented Sep 27, 2023

I am an org admin but not a maintainer of this plugin, and org admins generally do not merge changes for plugins they are not maintaining (even though they have the permissions to) as part of our social contract, unless some exception presents itself.

@jamietanna
Copy link
Contributor

All good, thought I'd ask! Would it be handy to have it released sooner than later?

@jamietanna jamietanna merged commit 59f4009 into jenkinsci:master Sep 27, 2023
16 checks passed
@basil basil deleted the default-driver branch September 27, 2023 15:32
@basil
Copy link
Member Author

basil commented Sep 27, 2023

Yes, it would be nice to get this cleaned up and released so that core can eventually remove the outdated driver once all consumers have been eliminated.

@jamietanna
Copy link
Contributor

@basil all released now, thanks for your patience 🚀

@basil
Copy link
Member Author

basil commented Oct 16, 2023

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants