Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added generic DSL support using metadata from Descriptors #816

Merged
merged 1 commit into from Apr 18, 2016

Conversation

@daspilker
Copy link
Member

daspilker commented Apr 1, 2016

No description provided.

@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented Apr 1, 2016

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@daspilker daspilker force-pushed the daspilker:symbols branch 9 times, most recently from 6f03a11 to b9235d8 Apr 4, 2016
@v1v

This comment has been minimized.

Copy link
Member

v1v commented Apr 9, 2016

👍

@daspilker daspilker force-pushed the daspilker:symbols branch 3 times, most recently from 643e5cc to 95c31ac Apr 10, 2016
@@ -1,3 +1,3 @@
version=1.46-SNAPSHOT
groovyVersion=1.8.9
githubUser=jenkinsci
githubUser=daspilker

This comment has been minimized.

Copy link
@sschuberth

sschuberth Apr 14, 2016

Member

This change should probably be reverted, or?

Vagrantfile Outdated
@@ -22,6 +22,10 @@ Vagrant.configure(2) do |config|
master.vm.network "forwarded_port", guest: 8080, host: 8081
master.vm.provision "shell", inline: $base_script
master.vm.provision "shell", inline: $script

master.vm.provider "virtualbox" do |provider|
provider.memory = 640

This comment has been minimized.

Copy link
@sschuberth

sschuberth Apr 14, 2016

Member

Why does this become necessary? This change should probably be split out into its own commit, providing a proper reasoning in the commit message.

@daspilker daspilker force-pushed the daspilker:symbols branch from 95c31ac to 6d5de14 Apr 14, 2016
@daspilker

This comment has been minimized.

Copy link
Member Author

daspilker commented Apr 14, 2016

@sschuberth thanks for the review, I removed those files from the commit

@daspilker daspilker force-pushed the daspilker:symbols branch from 6d5de14 to 91212ca Apr 15, 2016
@daspilker daspilker force-pushed the daspilker:symbols branch from 91212ca to 843ac64 Apr 18, 2016
@daspilker daspilker merged commit 843ac64 into jenkinsci:master Apr 18, 2016
1 check passed
1 check passed
Jenkins This pull request looks good
Details
@chbloemer

This comment has been minimized.

Copy link

chbloemer commented Apr 29, 2016

@daspilker is it possible to use the performance plugin with generic dsl? See: https://wiki.jenkins-ci.org/display/JENKINS/Performance+Plugin

@daspilker

This comment has been minimized.

Copy link
Member Author

daspilker commented May 2, 2016

@chbloemer yes, it's possible

@daspilker daspilker deleted the daspilker:symbols branch May 10, 2016
@itavero

This comment has been minimized.

Copy link
Member

itavero commented May 11, 2016

Is this included in release 1.46?

Update
I'm asking this because it does not work for me when I'm applying the "DSL Factory" pattern from the wiki.
I've added some additional information to the JIRA issue that should be "fixed" with this new feature:
https://issues.jenkins-ci.org/browse/JENKINS-22138

@sschuberth

This comment has been minimized.

Copy link
Member

sschuberth commented May 11, 2016

@itavero According to the release notes, yes.

@itavero

This comment has been minimized.

Copy link
Member

itavero commented May 11, 2016

So, I got a hunch why this does not work. As mentioned in the comment I added to JENKINS-22138, I'm running the script locally.
I reckon I need to add the plug-in to my classpath or something, right?

@itavero

This comment has been minimized.

Copy link
Member

itavero commented May 11, 2016

Totally missed this page, Automatically Generated DSL, which mentions some limitations in the last few paragraphs.
What I'm trying to achieve is not yet possible. 😉

@ghost

This comment has been minimized.

Copy link

ghost commented Oct 9, 2017

I am encountering problem while trying to automate the job creation process.
Target repository field is empty after trying multiple times.
below is the code I am using.

Any solutions how that value can be populated, or any other way to integrate DSL with artifactory that solves the problem.
I could not find any help on google and ended up with this same issue discussed here.
I am using the latest version of DSL plugin .

configure { project ->
project / buildWrappers << 'org.jfrog.hudson.generic.ArtifactoryGenericConfigurator' {
details {
artifactoryUrl('abc')
artifactoryName('abc')
deployReleaseRepository
{
keyFromText('node-plugin-release-local') keyFromSelect('') dynamicMode(true)

{color:#ff0000}}
}
deployPattern('.zip ')
matrixParams('')
deployBuildInfo(true)
includeEnvVars(true)
envVarsPatterns {
includePatterns('')
excludePatterns('password,secret,key')
}
discardOldBuilds(true)
discardBuildArtifacts(true)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.