feat: make pipeline support instanceCap field #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: containerCap and instanceCap judgement bug
iocanel
requested changes
Dec 6, 2016
There was a problem hiding this comment.
Since the PR adds instanceCap in PodTemplateStep we should also update https://github.com/jenkinsci/kubernetes-plugin/blob/028685683c02b9efdadb4a4c5e7f74cec4d7b206/src/main/resources/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStep/config.jelly
|
@zoumo: Thanks for the PR, I add a minor change request, so that its complete! Thanks again! |
|
@iocanel Hi, I have updated config.jelly. request review. |
iocanel
approved these changes
Dec 7, 2016
|
@zoumo: Thanks! This is used by the script generator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: make pipeline support instanceCap field
fix: containerCap and instanceCap judgement bug