[JENKINS-64006] Implement Dynamic PVC for volume pod template #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vlatombe
requested review from
twasyl,
amuniz,
mikecirioli,
kerogers-cloudbees and
aHenryJard
The existing logic in DynamicPVCWorkspaceVolume has been moved to a separate interface DynamicPVC, so that it can be shared with the new DynamicPVCVolume implementation.
Vlatombe
force-pushed
the
JENKINS-64006
branch
from
04f1c6d
to
fc09d5c
Compare
* help-mountPath.html * help-subPath.html
aHenryJard
reviewed
Dec 14, 2021
src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateBuilder.java
Outdated
Show resolved
Hide resolved
...rces/org/csanchez/jenkins/plugins/kubernetes/volumes/DynamicPVCVolume/help-requestsSize.html
Show resolved
Hide resolved
amuniz
approved these changes
Dec 14, 2021
src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/PodVolume.java
Show resolved
Hide resolved
src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/PodVolume.java
Outdated
Show resolved
Hide resolved
src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/PodVolume.java
Outdated
Show resolved
Hide resolved
src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/PodVolume.java
Outdated
Show resolved
Hide resolved
src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/DynamicPVCVolume.java
Outdated
Show resolved
Hide resolved
src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/DynamicPVC.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Antonio Muniz <amuniz@users.noreply.github.com>
| .withNewMetadata() | ||
| .withName("pvc-" + podMetaData.getName()) | ||
| .withOwnerReferences(ownerReference) | ||
| .withLabels(DEFAULT_POD_LABELS) |
There was a problem hiding this comment.
Why removed the labels here? I used the labels to distinguish PVC created by Jenkins, and found it not worked after I upgraded the plugin to the latest version. 😢
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic in DynamicPVCWorkspaceVolume has been moved to a
separate interface DynamicPVC, so that it can be shared with the new
DynamicPVCVolume implementation.
KubernetesPipelineTest#dynamicPVCas it was ambiguous with the new use caseKubernetesPipelineTest#dynamicPVCVolumetest