New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete the build pod after we have finished with the template block #172

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
3 participants
@rawlingsj

rawlingsj commented Jul 7, 2017

after using a build pod it can be common to wait for a pipeline approval, this change means the build pod doesn't hang around once we've finished with it

delete the build pod after we have finished with the template block
after using a build pod it can be common to wait for a pipeline approval, this change means the build pod doesn't hang around once we've finished with it

@iocanel iocanel self-requested a review Jul 12, 2017

@iocanel

LGTM

@carlossg: Do you think that being explicit about deleting the pod, could possibly solve the other issues on concurrent builds we discussed lately?

@carlossg

This comment has been minimized.

Show comment
Hide comment
@carlossg

carlossg Jul 12, 2017

some of the reused pod issues could be

carlossg commented Jul 12, 2017

some of the reused pod issues could be

@carlossg carlossg merged commit fb9a0a8 into jenkinsci:master Jul 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment