Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete the build pod after we have finished with the template block #172

Merged
merged 1 commit into from
Jul 12, 2017
Merged

delete the build pod after we have finished with the template block #172

merged 1 commit into from
Jul 12, 2017

Conversation

rawlingsj
Copy link
Member

after using a build pod it can be common to wait for a pipeline approval, this change means the build pod doesn't hang around once we've finished with it

@rawlingsj
delete the build pod after we have finished with the template block
de0bcba 
after using a build pod it can be common to wait for a pipeline approval, this change means the build pod doesn't hang around once we've finished with it
@iocanel iocanel self-requested a review July 12, 2017 07:05
iocanel
iocanel approved these changes Jul 12, 2017
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlossg: Do you think that being explicit about deleting the pod, could possibly solve the other issues on concurrent builds we discussed lately?

@carlossg
Copy link
Contributor

some of the reused pod issues could be

@carlossg carlossg merged commit fb9a0a8 into jenkinsci:master Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rawlingsj @carlossg @iocanel