Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused JENKINS_JNLP_URL env var #219

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Remove unused JENKINS_JNLP_URL env var #219

merged 1 commit into from
Sep 11, 2017

Conversation

carlossg
Copy link
Contributor

@carlossg carlossg commented Sep 8, 2017

No description provided.

@carlossg carlossg merged commit 4743c74 into master Sep 11, 2017
@carlossg carlossg deleted the remove-jnlp-env branch September 11, 2017 08:48
@marvinthepa
Copy link
Contributor

What was this used for? When did this become obsolete? Just asking out of curiosity :-).

@Vlatombe
Copy link
Member

It was used at one point in the slave image but got removed since (carlossg/jenkins-slave-docker@4b0d0f7).

@nehaljwani
Copy link
Contributor

Just saw this today and upgrading plugin to v1.1 broke my builds. I have been using my own container to connect to the jenkins master and used the following command to do so:

${JAVA} ${JAVA_OPTS} -jar ${SLAVE_JAR} -jnlpUrl ${JENKINS_JNLP_URL} -secret ${JENKINS_SECRET} -noReconnect

Any chance that this could be brought back? What's the recommended way? Should I be generating this URL on my own now?

@Vlatombe
Copy link
Member

Hi @nehaljwani
you can use ${JENKINS_URL}/computer/${JENKINS_NAME}/slave-agent.jnlp instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vlatombe Vlatombe Vlatombe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossg @marvinthepa @Vlatombe @nehaljwani