[JENKINS-50932] Combine parent pod template ports with children #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a commit which combines the ports section of a container with the parent container to work around the issue for our use case. It does nothing to fix the underlying issue with pod inheritance, which seems to be the cause for the issue we are seeing with host ports. |
carlossg
changed the title
It's expensive and already covered by PodTemplateUtilsTest#shouldCombineAllPorts
|
The bug described in JENKINS-50932 was fixed in 1.12.7, so I'm closing this. |
|
this is still useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a test which starts up two pods with host ports in parallel, and checks that they both get host ports. Tested in a minikube cluster to successfully expose the bug.