[JENKINS-50429] Use a bigger buffer for stdin on kubernetes exec #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use a lower value by default just in case, enough to make the tests pass
|
Please comment here what buffer size you need for your pipelines to work so we set a good default. |
|
Sounds nice! Did it solve the performance issues mentioned? |
|
This is great news! An typical command we run might be a ~100 bytes in length. Combining this with the set of env variables typically sent along with the command on exec looks to be around 4000 bytes. I'm not sure if there is any other data sent along with the command (global variables etc?). I suspect 8192 bytes would suffice in most cases - though this isn't very scientific... |
|
yes, this solves the performance and the test pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #425
Works around fabric8io/kubernetes-client#1008