[JENKINS-55392] Do not close Kubernetes client after containerLog step #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as it is being cached and reused
carlossg
changed the title
|
this may be enough and not need #418 |
jglick
reviewed
Jun 3, 2019
| .expireAfterWrite(CACHE_EXPIRATION, TimeUnit.SECONDS) | ||
| .newBuilder() // | ||
| .maximumSize(CACHE_SIZE) // | ||
| .expireAfterWrite(CACHE_EXPIRATION, TimeUnit.SECONDS) // |
| @@ -107,7 +107,7 @@ public boolean start() throws Exception { | |||
| @Override | |||
| public void stop(@Nonnull Throwable cause) throws Exception { | |||
| LOGGER.log(Level.FINE, "Stopping container step."); | |||
| closeQuietly(getContext(), client, decorator); | |||
| closeQuietly(getContext(), decorator); | |||
There was a problem hiding this comment.
BTW I would recommend getting rid of Resources.closeQuietly and switch to Java 7 suppressed exceptions—unless you have a specific reason to expect an exception from some close method which you have a specific reason to want to recover from, in which case write that explicitly. But the default should be to propagate failures.
Also I recommend all StepExecution subtypes delegate to super.stop unless you really know what you are doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as it is being cached and reused