Fixed an issue where only the last PodTemplateFilter would be applied #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Vlatombe are there any reported Jira issues we can mark fixed pending this PR? |
|
There is no bug for this, it is preventing me from implementing a new |
jglick
approved these changes
Jun 27, 2019
| @@ -33,9 +33,9 @@ | |||
| public static List<PodTemplate> applyAll(@Nonnull KubernetesCloud cloud, @Nonnull List<PodTemplate> podTemplates, @CheckForNull Label label) { | |||
| List<PodTemplate> result = new ArrayList<>(); | |||
| for (PodTemplate t : podTemplates) { | |||
| PodTemplate output = null; | |||
There was a problem hiding this comment.
Note that this changes behavior in the case that there are no filters. Previously, this function would return an empty list, which makes little sense; now it will return (a copy of) podTemplates unchanged, as you would expect. I suppose that bug was not previously noticed because PodTemplateLabelFilter is always registered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I missed it when I initially introduced the extension point in #288