Wait until all containers are in ready state before starting the slav… #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossg
reviewed
Nov 29, 2016
| }; | ||
|
|
||
| try (Watch watch = client.pods().withName(podName).watch(podWatcher)) { | ||
| if (latch.await(5, TimeUnit.MINUTES)) { |
There was a problem hiding this comment.
Can you put the 5 in a System.getProperty(ContainerExecDecorator.class.getName()+".containerReadyTimeout","5"); ?
…e or execute a script in container. Improve error messages.
|
@carlossg: pushed and squashed. |
|
I'm not sure yet why, but this PR broke the plugin for me. The build just hangs on the first The container was definitely ready, as I can see all containers in the pod marked as "Running" when inspecting the pods on Kubernetes. Furthermore, the |
|
yeah, there is a PR at #95 to try to solve it |
|
Ah sorry, missed that one. Thank you for the pointer 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e or execute a script in container. Improve error messages.