Mailer: fix missing getter for smtpHost property #42
Conversation
required for configuration-as-code Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
|
A JIRA issue would help
…On Sat, Sep 8, 2018, 00:08 Joseph Petersen ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#42 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC3IoHygJx6QpJ9hZIylGnuhBLqoDw2nks5uYu5UgaJpZM4We1jO>
.
|
|
Silly oleg 🙄 there is one, yet linked in the jcasc github issue: jenkinsci/configuration-as-code-plugin#501 |
|
By the way: the Delphi language has an own concept for such things, called 'properties'. Looks like dumb fields to the outside, but one can attach getter/setter code if needed. Could we do something similar in Java ? |
|
It is under discussion for future Java versions. Some languages like C#
support it.
…On Sat, Sep 8, 2018, 14:39 Enrico Weigelt ***@***.***> wrote:
By the way: the Delphi language has an own concept for such things, called
'properties'. Looks like dumb fields to the outside, but one can attach
getter/setter code if needed.
Could we do something similar in Java ?
Problems like this seem to be pretty common (eg. I've just got a report on
the same problem w/ the extended mailer plugin).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC3IoCFlAEg8Gq_RL-Ha17e_3SL9ACl2ks5uY7qPgaJpZM4We1jO>
.
|
|
IIRC it has first been proposed for ... Java 6! |
|
On 08.09.2018 14:59, Oleg Nenashev wrote:
It is under discussion for future Java versions. Some languages like C#
support it.
For our case - when using reflection anyways - there could be a simpler
solution: make those attributes public fields or add some annotation,
so casc+friends could access these fields directly.
Haven't checked whether something calls these getters/setters directly,
or everything (eg. UI, etc) goes via reflection. In that case, we could
get rid of all the trivial getters/setters (only leaving those which
really need something special).
…--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
|
|
getter + setter is a very common Java construct, long debated as boilerplate and sometime generated (see Lombok) |
|
Hi. I'm also looking for this fix to use configuration-as-code for automation. Is there anything that prevents this PR to be merged? If not, please do it. |
|
So, now we have 3 approvals, a Jira issue and a long discussion. What else is required to have that missing getter added? Kind regards, |
|
I guess : someone to actively maintain this plugin :) |
|
well @daniel-beck and @jglick released last, and @oleg-nenashev appears to have commit access 😉 |
|
Both releases were for security fixes, this does not indicate maintainership. |
|
@daniel-beck Does this mean, that the plug-in is not maintained? |
|
@jglick I believe you are formally the maintainer then. Would you be fine if I also formally join the maintenance team so that I deliver the stuff? |
|
I am not a maintainer. If you would like to take over, go ahead. |
|
@olivergondza seems you're maintainer on mailer plugin, can you please check this ? (and maybe have a look at #39 for a larger scope fix for casc-compatibility) |
|
Let's just call Jenkins core team as maintainers. Will do the job |
|
@oleg-nenashev Thank you very much! |
1 similar comment
|
@oleg-nenashev Thank you very much! |
required for configuration-as-code
Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net