Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set source level for maven-javadoc-plugin #39

Merged
merged 1 commit into from
May 2, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented May 1, 2019

Analogue of jenkinsci/plugin-pom#196.

Was unable to verify that this allows the jdk11 profile to be deleted from jenkinsci/jenkins/pom.xml, since I could not compile Jenkins core at all under Java 11 (error in CrontabParser). I did at least confirm that it causes -source 8 to appear in core/target/apidocs/options as expected when using -Ddebug.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't hurt at least

@batmat batmat merged commit 23da954 into jenkinsci:master May 2, 2019
@jglick
Copy link
Member Author

jglick commented May 2, 2019

It won't hurt at least

I will never promise that!

@jglick jglick deleted the javadoc branch May 2, 2019 13:55
@oleg-nenashev
Copy link
Member

Still needs a release

@oleg-nenashev
Copy link
Member

Shipped in 1.52.
FYI @jenkinsci/java11-support , Jenkins core can be updated now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants