Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing override annotations #388

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Add missing override annotations #388

merged 1 commit into from
Jul 6, 2020

Conversation

basil
Copy link
Member

@basil basil commented Jul 1, 2020

This PR applies the IntelliJ "Add missing @Override annotations" automated refactoring tool against the entire codebase. This convention is used by most modern Java style guides, including Google Java Style Guide §6.1.

@jeffret-b jeffret-b self-requested a review July 2, 2020 17:14
jeffret-b
jeffret-b approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@jeffret-b jeffret-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission.

Adding these annotations is another good maintenance chore that improves the code and makes it easier to maintain.

@jeffret-b jeffret-b added chore For changelog: A maintenance chore with no functional changes ready-to-merge labels Jul 2, 2020
@basil basil mentioned this pull request Jul 2, 2020
Merged
@jeffret-b jeffret-b merged commit cff197b into jenkinsci:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffret-b jeffret-b jeffret-b approved these changes

Assignees
No one assigned
Labels
chore For changelog: A maintenance chore with no functional changes ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basil @jeffret-b