[JENKINS-63520] Sequence the startup and receiving to avoid a deadlock. #445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-63520.
Some users have reported a rare thread deadlock when starting an inbound TCP agent. There are no known reports of this occurring at other times. The reporter included a stack track showing information about the deadlock. It occurs when the agent ProtocolStack is still initializing and a message is received on the networking layer.
Personally, I've never observed the problem and have no way of testing it. I've tested normal behavior and this fix has worked fine.
This fix delays the processing of any received messages until after the ProtocolStack has fully initialized.