Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update htmlunit to 3.x #464

Merged
merged 2 commits into from
May 29, 2023
Merged

Update htmlunit to 3.x #464

merged 2 commits into from
May 29, 2023

Conversation

timja
Copy link
Member

@timja timja commented May 25, 2023

Part of jenkinsci/jenkins-test-harness#568

Testing done

Tests passed locally

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja mentioned this pull request May 25, 2023
Closed
timja
timja commented May 29, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@timja timja marked this pull request as ready for review May 29, 2023 14:52
@timja timja requested a review from basil May 29, 2023 14:57
basil
basil approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit 0537faf into jenkinsci:master May 29, 2023
@timja timja deleted the update-htmlunit branch May 29, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timja @basil