User account mapping

[smalik86]

Hi @olivierdagenais , these are my testing results.

I ran the build through Maven and made sure that the jar and hpi files were successfully created.
Once the hpi file was created, I uploaded the file and installed it on our company's Test Jenkins.
The plugin worked as expected and the UI interface made it easy for us to chose whether to keep the User ID with the domain name or User ID without the domain name.

Example: DomainName/User ID to Only User ID

[olivierdagenais]

Those are some mice commits, @smalik86! 😃

Given I haven't personally done any testing, I'm assuming you found these changes to be satisfactory at your organization? If so, can I trouble you to add a comment to this pull request with the validation you performed? A great example of what I'm looking for can be seen in the Manual Testing section of #136.

Thanks!
- Oli

[smoyen]

Manual testing

Test 1: In Manage Jenkins > Configure System, set User account name mapping strategy is set to Resolve user using ‘alias’ only, removing ‘DOMAIN\’

1. Create a job using TFS for source control and turn polling on
2. Check in a change
3. After the build kicks off, examine the user listed in the changes. Notice that it does not include the domain
4. If your Jenkins user ids do not include the domain, you will have the added benefit of the build history for a user including build kicked off Manually and by SCM Trigger

Test 2: In Manage Jenkins > Configure System, set User account name mapping strategy is set to Resolve user using ‘DOMAIN\alias’

1. Create a job using TFS for source control and turn polling on
2. Check in a change
3. After the build kicks off, examine the user listed in the changes. Notice that it does include the domain
4. If your Jenkins user ids do not include the domain, the build histories for builds kicked off Manually and by SCM Trigger will be listed under separate users (i.e. Manually builds will be listed under user named userId and SCM Trigger builds will be listed under user named domainName_userId)

*Jobs that use anything besides TFS for source control are not affected. Manual Build user name is not affected for TFS and non-TFS sourced jobs.

[olivierdagenais]

@smalik86 and @smoyen: Thank you for validating these changes! Your contribution is greatly appreciated.