Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly setup default unlimited maxFormKeys as default #394

Closed

Conversation

olamy
Copy link
Member

@olamy olamy commented Jun 26, 2024

Signed-off-by: Olivier Lamy olamy@apache.org

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
Copy link
Member Author

olamy commented Jun 26, 2024

btw those unlimited values could be dangerous (ddos attack) but I have no real idea about what sort of possible values could work for Jenkins (1000 is already a lot)

@olamy
Copy link
Member Author

olamy commented Jun 26, 2024

from #393 (comment)

looks to be fixed as well with the next PR #395

@olamy olamy closed this Jun 26, 2024
@olamy olamy deleted the correctly-honour-max-param-count-for-max-form-keys branch June 26, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant