[JENKINS-26130] Way to print progress from pickles #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2016
| @@ -180,7 +182,11 @@ public void onSuccess(List<StepExecution> result) { | |||
|
|
|||
| @Override | |||
| public void onFailure(Throwable t) { | |||
| LOGGER.log(WARNING, null, t); | |||
| if (t instanceof CancellationException) { | |||
| LOGGER.log(Level.FINE, "cancelled load of " + e, t); | |||
There was a problem hiding this comment.
NIT: start entries from the uppercase letter?
There was a problem hiding this comment.
Not sure if there is any particular convention.
There was a problem hiding this comment.
But maybe makes sense to keep in consistent within Pipeline plugin at least
|
🐝 for the implementation, 🐜 for annotations and naming. Mostly NIT |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
re-:bee: |
|
🐝 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-26130
@reviewbybees