Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-26130] Way to print progress from pickles #5

Merged
merged 4 commits into from Jun 16, 2016

Conversation

Projects
None yet
4 participants
@jglick
Copy link
Member

jglick commented Jun 9, 2016

jglick added some commits Jun 10, 2016

@@ -180,7 +182,11 @@ public void onSuccess(List<StepExecution> result) {

@Override
public void onFailure(Throwable t) {
LOGGER.log(WARNING, null, t);
if (t instanceof CancellationException) {
LOGGER.log(Level.FINE, "cancelled load of " + e, t);

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Jun 10, 2016

Member

NIT: start entries from the uppercase letter?

This comment has been minimized.

Copy link
@jglick

jglick Jun 10, 2016

Author Member

Not sure if there is any particular convention.

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Jun 10, 2016

Member

But maybe makes sense to keep in consistent within Pipeline plugin at least

@@ -109,6 +111,14 @@ public String getUrlOfExecution() throws IOException {
public abstract int hashCode();

/**
* Gets a listener to which we may print general messages.
* Normally {@link StepContext#get} should be used, but in some cases there is no associated step.
*/

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Jun 10, 2016

Member

@since
Maybe also getTaskListener()

This comment has been minimized.

Copy link
@jglick

jglick Jun 10, 2016

Author Member

Generally have not bothered with @since on these plugin APIs. If you are already depending on the version that has it, there is little reason to care when it was introduced. If you are not, then you will not know it exists, unless you are browsing sources on GitHub or something. When in doubt, use the latest version.

/**
* A placeholder implementation for use in compatibility stubs.
*/
public static FlowExecutionOwner dummyOwner() {

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Jun 10, 2016

Member

@since.

I would also use DummyFlowExecutionOwner#getInstance()

This comment has been minimized.

Copy link
@jglick

jglick Jun 10, 2016

Author Member

I would also use DummyFlowExecutionOwner#getInstance()

Could; just more verbose for no gain.

return new DummyOwner();
}

private static class DummyOwner extends FlowExecutionOwner {

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Jun 10, 2016

Member

NIT, maybe just DefaultImpl

This comment has been minimized.

Copy link
@jglick

jglick Jun 10, 2016

Author Member

Well I wanted to be clear that it is not a “default”, it is really a stub.

This comment has been minimized.

Copy link
@oleg-nenashev
@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Jun 10, 2016

🐝 for the implementation, 🐜 for annotations and naming. Mostly NIT

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Jun 15, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Jun 15, 2016

re-🐝

@abayer

This comment has been minimized.

Copy link
Member

abayer commented Jun 15, 2016

🐝 as well

@jglick jglick merged commit d85f3c2 into jenkinsci:master Jun 16, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:PPPP-JENKINS-26130 branch Jun 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.