[JENKINS-26130] Way to print progress from pickles #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tem from ExecutorPickle automatically. (Cancelling that queue item, rather than the main build, already worked: QueueTaskFuture.get throws an exception.)
| } else { | ||
| item = Queue.getInstance().getItem(itemID); | ||
| if (item == null) { | ||
| throw new IllegalStateException("queue lost item #" + itemID); |
There was a problem hiding this comment.
I'm not sure if it's safe if the QueueTask gets completed quickly
There was a problem hiding this comment.
Queue.leftItems keeps things for five minutes, much longer than the recurrence period for this pickle.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
🐝 |
|
To paraphrase Eddie Izzard, "I like my pull requests like I like my coffee - covered in 🐝s" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of jenkinsci/workflow-api-plugin#5, jenkinsci/workflow-support-plugin#4, jenkinsci/workflow-job-plugin#5, and jenkinsci/workflow-cps-plugin#20.
@reviewbybees