Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-26130] Way to print progress from pickles #6

Merged
merged 10 commits into from Jun 16, 2016

Conversation

Projects
None yet
4 participants

@jglick jglick closed this Jun 10, 2016

@jglick jglick reopened this Jun 10, 2016

Overriding TryRepeatedly.cancel allows us to delete the stray queue i…
…tem from ExecutorPickle automatically.

(Cancelling that queue item, rather than the main build, already worked: QueueTaskFuture.get throws an exception.)
} else {
item = Queue.getInstance().getItem(itemID);
if (item == null) {
throw new IllegalStateException("queue lost item #" + itemID);

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Jun 10, 2016

Member

I'm not sure if it's safe if the QueueTask gets completed quickly

This comment has been minimized.

Copy link
@jglick

jglick Jun 10, 2016

Author Member

Queue.leftItems keeps things for five minutes, much longer than the recurrence period for this pickle.

LOGGER.log(Level.WARNING, "failed to cancel {0}", item);
}
}
return super.cancel(mayInterruptIfRunning);

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Jun 10, 2016

Member

Is it really required?

This comment has been minimized.

Copy link
@jglick

jglick Jun 10, 2016

Author Member

Which part? The Queue.cancel call removes the part of … task from the queue, which the last line of unloadableExecutorPickle asserts. The super.cancel stops the retrying in TryRepeatedly (though the next try would probably fail anyway, in QueueTaskFuture.get).

This comment has been minimized.

Copy link
@oleg-nenashev
@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Jun 13, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Jun 15, 2016

🐝

@abayer

This comment has been minimized.

Copy link
Member

abayer commented Jun 15, 2016

To paraphrase Eddie Izzard, "I like my pull requests like I like my coffee - covered in 🐝s"

@jglick jglick merged commit b154b61 into jenkinsci:master Jun 16, 2016

1 check was pending

Jenkins Jenkins is validating pull request ...
Details

@jglick jglick deleted the jglick:PPPP-JENKINS-26130 branch Jun 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.