Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-26130] Allow pickle rehydration to be interrupted #20

Merged
merged 7 commits into from Jun 16, 2016

Conversation

Projects
None yet
3 participants
// If we are still rehydrating pickles, try to stop that now.
Collection<ListenableFuture<?>> futures = pickleFutures;
if (futures != null) {
LOGGER.log(Level.FINE, "we are still rehydrating pickles in {0}", owner);

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Jun 10, 2016

Member

🐜 lowercase again. In this method both lowercase and uppercase letters are being used, so it is a kind of mess

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Jun 10, 2016

Mostly LGTM

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Jun 15, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Jun 15, 2016

re-🐝

@jglick jglick merged commit 539b838 into jenkinsci:master Jun 16, 2016

1 check was pending

Jenkins Jenkins is validating pull request ...
Details

@jglick jglick deleted the jglick:PPPP-JENKINS-26130 branch Jun 16, 2016

svanoort added a commit that referenced this pull request Apr 6, 2017

Merge pull request #20 from jenkinsci/final-parallel-branch-ordering
Ensure that for SimpleBlockVisitor we find the REAL last branch for a parallel [JENKINS-38536]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.