[JENKINS-26130] Allow pickle rehydration to be interrupted #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // If we are still rehydrating pickles, try to stop that now. | ||
| Collection<ListenableFuture<?>> futures = pickleFutures; | ||
| if (futures != null) { | ||
| LOGGER.log(Level.FINE, "we are still rehydrating pickles in {0}", owner); |
There was a problem hiding this comment.
🐜 lowercase again. In this method both lowercase and uppercase letters are being used, so it is a kind of mess
|
Mostly LGTM |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
re-:bee: |
svanoort
added a commit
that referenced
this pull request
Apr 6, 2017
Ensure that for SimpleBlockVisitor we find the REAL last branch for a parallel [JENKINS-38536]
dwnusbaum
pushed a commit
to dwnusbaum/workflow-cps-plugin
that referenced
this pull request
Jun 1, 2020
[JENKINS-32062] Arrays could not be passed directly to methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of jenkinsci/workflow-api-plugin#5, jenkinsci/workflow-support-plugin#4, and jenkinsci/workflow-job-plugin#5.
@reviewbybees