-
Notifications
You must be signed in to change notification settings - Fork 902
[JENKINS-26093] Better support for build step parameters #69
[JENKINS-26093] Better support for build step parameters #69
Conversation
… their index pages.
@reviewbybees should be ready for review. |
👍 from me but did you ever resolve the |
👍 |
<script> | ||
function loadParams() { | ||
var div = $$('params'); | ||
new Ajax.Request('${descriptor.descriptorUrl}/parameters?job=' + encodeURIComponent($$('${jobFieldId}').value), { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just occurred to me that this will not handle relative paths, need to fix that.
Conflicts: CHANGES.md
Build 953 from 495edb4 was stable (the PR builder is having trouble noting that here), so again @reviewbybees. |
I'm still 👍 but I think we want @kohsuke to review the |
👍 Note sure I totally understand it though ( |
Regarding Here (in 72860e9, the non-UI part of the PR) I am going with a more conservative change. |
|
Part of JENKINS-26093 so far.
@reviewbybees