Alternate approach to SemaphoreStep using Timer #259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
commented
Mar 28, 2024
Comment on lines
-148
to
-155
| /** @deprecated should not be needed */ | ||
| @Deprecated | ||
| public StepContext getContext() { | ||
| State s = State.get(); | ||
| synchronized (s) { | ||
| return getContext(s, k()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Could be restored if needed, but I didn't see any callers in a quick search, and IDK how it would even be used in the first place. Deleting this though allows us to totally drop State.contexts.
| @Override public String getStatus() { | ||
| State s = State.get(); | ||
| synchronized (s) { | ||
| return "waiting on " + k; |
There was a problem hiding this comment.
Message is less precise now, could be restored if needed.
This was referenced Mar 28, 2024
jglick
reviewed
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #258 that aims for simplicity over performance. More or less untested, and at the very least it changes some of the logging, so we'd probably want to run the PCT against this first if we want to try this approach.