-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for recurring full day events east of UTC #42
fix for recurring full day events east of UTC #42
Conversation
lint forced change to includes from indexOf.. I didn't check the results of the function.. 'assumed' it was the same... not.. |
Thanks for the new PR. this looks much cleaner. The only thing missing is, that you please should add a new dedicated test for your particular change/enhancement so that in future npm test will test your fix and no further regression happens in case another change might bring back an issue again. So please add a new testcase to this PR. |
perfect! thanks for the nice contribution! |
should be 12.3, right? as u already published 12.2 |
yes, as soon as I will publish 0.12.3 this change will be included. I am just hoping someone can take care of #14 so that I can release it ASAP. |
got it.. we have a matching issue, but haven't been able to get anyone to send a testcase that actually fails. |
fix #36