Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make git clone work on Windows #7

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

wtwhite
Copy link
Collaborator

@wtwhite wtwhite commented Aug 15, 2023

Attempting git clone on Windows fails due to a colon in the filename src/test/resources/artifacts/org.apache.commons:commons-collections4.json:

C:\Users\walto\Documents\code>git clone git@github.com:jensdietrich/shadedetector.git
Cloning into 'shadedetector'...
remote: Enumerating objects: 2481, done.
remote: Counting objects: 100% (476/476), done.
remote: Compressing objects: 100% (266/266), done.
remote: Total 2481 (delta 166), reused 392 (delta 92), pack-reused 2005
Receiving objects: 100% (2481/2481), 971.22 KiB | 991.00 KiB/s, done.
Resolving deltas: 100% (1295/1295), done.
error: invalid path 'src/test/resources/artifacts/org.apache.commons:commons-collections4.json'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Changing the colon to an exclamation mark fixes this. mvn package succeeds before and after this change.

@jensdietrich jensdietrich merged commit 5549927 into main Aug 15, 2023
@wtwhite wtwhite deleted the fix-enable-git-clone-on-windows branch August 15, 2023 20:15
@wtwhite wtwhite restored the fix-enable-git-clone-on-windows branch August 15, 2023 20:16
@wtwhite wtwhite deleted the fix-enable-git-clone-on-windows branch August 15, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants