You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The span is superfluous, but if we put translate="yes" on the <button /> then translators will see a placeholder for the <Icon />, which is not helpful.
If a wrapper has leading or trailing elements with no text content, we should absorb them into the wrapper. Then you can safely do:
<buttononClick={this.close}translate="yes"><IconclassName="i-close" />
Close
</button>
refs #3, #4
ensure that leading/trailing standalone elements in wrappers and in the
top-level interpolator are preserved
also ensure that nested tags in wrappers area applied correctly
Another thing for nicer translation strings... Consider:
The span is superfluous, but if we put
translate="yes"
on the<button />
then translators will see a placeholder for the<Icon />
, which is not helpful.If a wrapper has leading or trailing elements with no text content, we should absorb them into the wrapper. Then you can safely do:
an the extracted string will just be:
"Close"
i18nliner-handlebars and canvas_react_i18n both do this, we should too.
The text was updated successfully, but these errors were encountered: