Hidden review issues from users without email

[Zitrax]

We had one user adding issues but forgetting to submit them, in the mean time the review was closed.

When the issues were eventually submitted the following day on the closed review they are invisible on the main review page. However if following the link in the worklog where it say "raised X issues", they show up as "Still open issues".

Not a big issue - but thought I should mention it since it was a bit confusing.

[jensl]

I would guess the fact that they're missing from the main review page is simply a caching issue. Have you tried force-reloading the page, or similar? (That's known to be a problem sometimes, whereas I can't think of any mechanism that would hide submitted issues.)

[Zitrax]

I debugged this a bit and it turned out that the user who submitted this was new and had not set his email. Thus this was a user without an entry in the useremails table.

And the code that displays all issues on a review is joining on that table, thus no issues from that user were shown. Setting up his email caused the issues to appear.

So it seems this had nothing to do with the fact that they were submitted on a closed review.

Maybe the join could be changed to not exclude such users, or users could be forced to set an email address.

[jensl]

Ah, cool. Thanks for investigating this!

Having an email address is supposed to be optional, so the correct solution ought to be to fix the join.