Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using an incorrect path in a filter causes exceptions #48

Closed
jgraham opened this issue Jun 28, 2013 · 2 comments
Closed

Using an incorrect path in a filter causes exceptions #48

jgraham opened this issue Jun 28, 2013 · 2 comments

Comments

@jgraham
Copy link

jgraham commented Jun 28, 2013

When invalid paths like /foo are encountered, critic starts throwing exceptions e.g.

Traceback (most recent call last):
File "critic/operation/init.py", line 328, in call
try: return self.process(db, user, **value)
File "critic/src/critic/operation/manipulatefilters.py", line 296, in process
"count": counts[filter_path] })
KeyError: '/webdriver/'

and some others. It should instead handle such errors gracefully,or, if possible, not error at all e.g. by treating /foo/ as the same as foo/.

@jensl
Copy link
Owner

jensl commented Jun 28, 2013

I think this might be fixed by http://critic-review.org/7fab6a1f?review=117 (which is not on master yet.)

@mo
Copy link
Collaborator

mo commented Jul 12, 2013

Looks like it works on master now. Closing.

@mo mo closed this as completed Jul 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants