Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to override language file #191

Closed
wants to merge 3 commits into from

Conversation

kmbriedis
Copy link

Adds an option to create custom language file in directory mentioned in https://laravel.com/docs/5.2/localization#overriding-vendor-language-files, to override existing or creating new language file in Laravel 5.1 and 5.2.

Solves issue #188

@danhunsaker
Copy link

I would strongly recommend documenting direct usage of the $resource parameter, so non-Laravel projects know how they can take advantage of this enhancement as well.

@kmbriedis
Copy link
Author

@danhunsaker does the last commit solve what you meant or did you mean more explict documentation?

@danhunsaker
Copy link

Not quite. It's good for Laravel users to know, but still doesn't address non-Laravel users. These users will be better served by knowing they can pass the $resourcePath to Date:setLocale() manually, which will let them put those files wherever makes sense for their own projects, instead of being forced into Laravel's paradigm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants