Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change in Readme #228

Closed
wants to merge 1 commit into from
Closed

Minor change in Readme #228

wants to merge 1 commit into from

Conversation

mkwsra
Copy link
Contributor

@mkwsra mkwsra commented Oct 23, 2016

No description provided.

@danhunsaker
Copy link

Can you re-trigger the Travis builds? They were run just before the day changed, so the time between creating a Date object, and the subsequent test, was just long enough to throw off the return values, causing the tests to fail.

No, you didn't break anything, but it's still nice to ensure the tests run properly after any change, even ones that don't change any actual code.

@danhunsaker
Copy link

That said, the ::class construct isn't available until PHP 5.5, so as long as the library supports 5.4, it's not actually a good idea to merge this change. I personally prefer the ::class syntax, as I'm sure you do, but we have to stick to what's officially supported regardless. 🙁

@mkwsra
Copy link
Contributor Author

mkwsra commented Oct 24, 2016

Okay, thanks a lot 😄

@mkwsra mkwsra closed this Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants