Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change for Arabic translation regarding (from now :time) #245

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

mkwsra
Copy link
Contributor

@mkwsra mkwsra commented Jun 26, 2017

In Arabic we don't say (from now :time) we say (:time from now):

Arabic examples:
من الآن 8 أشهر
8 أشهر من الآن

The line at the very above this one might seem strange that is because Github's website is LTR, not RTL!

I ran into this problem in multiple projects, so please accept this minor change.

BTW:

How can I add another Arabic language? like ar_SY?

In Syria, we call the months by different names! please tell me how can I do so by telling me or sharing a link. thanks in advance

In Arabic we don't say (from now :time) we say (:time from now):

Arabic examples:
من الآن 8 أشهر
8 أشهر من الآن 

The line at the very above this one might seem strange that is because Github's website is LTR, not RTL!

I ran into this problem in multiple projects, so please accept this minor change.

BTW:

How can I add another Arabic language? like ar_SY?

In Syria, we call the months by different names! please tell me how can I do so by telling me or sharing a link. thanks in advance
@jenssegers
Copy link
Owner

Can someone else verify if this correct?

@mkwsra mkwsra changed the title Minor change for Arabic translation reading (from now :time) Minor change for Arabic translation regarding (from now :time) Jun 26, 2017
@mkwsra
Copy link
Contributor Author

mkwsra commented Jun 26, 2017

To make things more visually right, regarding RTL websites, see the selected area
screen shot 2017-06-26 at 5 26 52 pm

@bymoe
Copy link

bymoe commented Jun 26, 2017

This is correct.

@jenssegers jenssegers merged commit 7cf7503 into jenssegers:master Jun 26, 2017
@hassoon3
Copy link

Correct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants