Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese localization. #57

Merged
merged 4 commits into from
Oct 10, 2014
Merged

Add Japanese localization. #57

merged 4 commits into from
Oct 10, 2014

Conversation

kerryusry
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.22%) when pulling 2690915 on kuseattle:master into 9b0da0a on jenssegers:master.

@kerryusry
Copy link
Contributor Author

Is there something I did wrong with the pull request, let me know.

@jenssegers
Copy link
Owner

Sorry for the delayed response. Could you also add translations for the other keys?

@kylekatarnls
Copy link
Contributor

Yes the build faield see the Travis details:
tests/TranslationTest.php:80

Also there must not be spaces before and after caracters I think.

@kerryusry
Copy link
Contributor Author

Sorry about the delay on getting the translation updated, originally I had the wrong lang file, now it has been updated.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) when pulling 112a7d2 on kuseattle:master into 9b0da0a on jenssegers:master.

@kylekatarnls
Copy link
Contributor

Probably not commited or pushed: all is in english here:
https://github.com/kuseattle/laravel-date/blob/master/src/lang/ja/date.php

@jenssegers
Copy link
Owner

Where can I find the file with all items translated?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) when pulling c7e318c on kuseattle:master into 9b0da0a on jenssegers:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) when pulling c7e318c on kuseattle:master into 9b0da0a on jenssegers:master.

@kerryusry
Copy link
Contributor Author

Thanks I am done there was a couple of minor tweaks after getting back from our translator. Cheers.

@jenssegers
Copy link
Owner

Thanks!

jenssegers added a commit that referenced this pull request Oct 10, 2014
Add Japanese localization.
@jenssegers jenssegers merged commit f4b6eb2 into jenssegers:master Oct 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants