-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibilty with mu4e 1.12 #190
base: master
Are you sure you want to change the base?
Conversation
danielfleischer
commented
Apr 13, 2024
- Collection of various patches to make org-msg compatible with mu 1.12+.
- It will break compatibility with older versions as there are major changes in the mu library.
Hi I did some test on this branch, there is a small problem I noticed:
However, the mail can be sent succesfully though. I have no idea what does this message mean. |
Try to comment the line:
I thought that isn't needed but some people came up with that fix. Also, are you following the latest code, not just the official 1.12 release? |
I'm also experiencing a similar problem: After sending a mail I see the buffer with mail converted to HTML and the buffer marked as modified. The minibuffer contains a message 'Text is read-only'. The mail is successfully sent. |
Yes, you should use mu4e from master as there were many updates to the composing code after the official release. Perhaps I should have been more explicit, as the the 1.12 code changes fast. |
if this is the case, perhaps we can’t merge this PR now? If this PR relies on the master branch code and has unresolved problems on official release. Since I believe most of people will just follow the official release (probably install from their package manager) instead of building from the source? |
Well, there was a 1.12.4 release a couple of days ago, containing the fixes I'm talking about. So no need to compile from master, just make sure you are updating, and not use the original 1.12.0 from February. |
Just updated my mu to |